Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(mpa): support mpa fallback #10985

Merged
merged 1 commit into from Nov 20, 2022
Merged

Conversation

sun0day
Copy link
Member

@sun0day sun0day commented Nov 18, 2022

Description

fixes #10966

Additional context


What is the purpose of this pull request?

  • Bug fix
  • New Feature
  • Documentation update
  • Other

Before submitting the PR, please make sure you do the following

  • Read the Contributing Guidelines.
  • Read the Pull Request Guidelines and follow the Commit Convention.
  • Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
  • Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123).
  • Ideally, include relevant tests that fail without this PR but pass with it.

@benmccann
Copy link
Collaborator

the docs would need to be updated: https://vitejs.dev/config/shared-options.html#apptype

@benmccann
Copy link
Collaborator

@brillout you might be interested in taking a look at this PR

@bluwy bluwy added feat: html p3-minor-bug An edge case that only affects very specific usage (priority) labels Nov 19, 2022
@brillout
Copy link
Contributor

What’s the difference between returning undefined and returning request.url?

@bluwy
Copy link
Member

bluwy commented Nov 20, 2022

Undefined will crash the server instead of calling next() per the issue.

@patak-dev
Copy link
Member

@benmccann would you do another PR modifying the docs if you see something to improve there? I don't see references to the fallback right now there that should be updated.

@patak-dev patak-dev merged commit 61165f0 into vitejs:main Nov 20, 2022
@benmccann benmccann mentioned this pull request Nov 20, 2022
9 tasks
fc pushed a commit to fc/vite that referenced this pull request Nov 23, 2022
@brillout
Copy link
Contributor

Undefined will crash the server instead of calling next() per the issue.

👍 I don't see any objections then.

bluwy pushed a commit that referenced this pull request Nov 29, 2022
patak-dev pushed a commit that referenced this pull request Nov 30, 2022
* fix(config): exclude config.assetsInclude empty array (#10941)

fixes #10926

* feat(css): upgrade postcss-modules (#10987)

* fix(mpa): support mpa fallback (#10985)

fixes #10966

* fix: export preprocessCSS in CJS (#11067)

* chore: update license

Co-authored-by: sun0day <sun_day500@163.com>
Co-authored-by: Jason Quense <monastic.panic@gmail.com>
Co-authored-by: sun0day <ivan.xu@applovin.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feat: html p3-minor-bug An edge case that only affects very specific usage (priority)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Vite dev server crashes with appType mpa on root URI
6 participants