fix: resolve addons using nodeResolve() (#5809)

vitejs · Nov 23, 2021 · d288772 · d288772
1 parent 4c17252
commit d288772
Show file tree

Hide file tree

Showing 6 changed files with 175 additions and 22 deletions.
diff --git a/packages/playground/ssr-vue/__tests__/ssr-vue.spec.ts b/packages/playground/ssr-vue/__tests__/ssr-vue.spec.ts
@@ -163,3 +163,9 @@ test('deep import built-in module', async () => {
   await page.goto(url)
   expect(await page.textContent('.file-message')).toMatch('fs/promises')
 })
+
+test('msg should encrypted', async () => {
+  // raw http request
+  const homeHtml = await (await fetch(url + '/')).text()
+  expect(homeHtml).not.toMatch('Secret Message!')
+})
diff --git a/packages/playground/ssr-vue/package.json b/packages/playground/ssr-vue/package.json
@@ -14,6 +14,7 @@
     "debug": "node --inspect-brk server"
   },
   "dependencies": {
+    "bcrypt": "^5.0.1",
     "example-external-component": "file:example-external-component",
     "vue": "^3.2.21",
     "vue-router": "^4.0.0",

diff --git a/packages/playground/ssr-vue/src/pages/Home.vue b/packages/playground/ssr-vue/src/pages/Home.vue
@@ -9,6 +9,7 @@
   <p class="inter">this will be styled with a font-face</p>
   <p class="import-meta-url">{{ state.url }}</p>
   <p class="protocol">{{ state.protocol }}</p>
+  <div>encrypted message: <p class="encrypted-msg">{{ encryptedMsg }}</p></div>
 
   <ImportType />
 </template>
@@ -27,10 +28,15 @@ const url = import.meta.env.SSR
   ? import.meta.url
   : document.querySelector('.import-meta-url').textContent
 const protocol = new URL(url).protocol
+const encryptedMsg = import.meta.env.SSR
+  ? await (await import('bcrypt')).hash('Secret Message!', 10)
+  : document.querySelector('.encrypted-msg').textContent
+
 const state = reactive({
   count: 0,
   protocol,
-  url
+  url,
+  encryptedMsg
 })
 </script>
 

diff --git a/packages/playground/ssr-vue/vite.config.js b/packages/playground/ssr-vue/vite.config.js
@@ -5,6 +5,9 @@ const vueJsx = require('@vitejs/plugin-vue-jsx')
  * @type {import('vite').UserConfig}
  */
 module.exports = {
+  optimizeDeps: {
+    exclude: ['bcrypt']
+  },
   plugins: [
     vuePlugin(),
     vueJsx(),

diff --git a/packages/vite/src/node/ssr/ssrModuleLoader.ts b/packages/vite/src/node/ssr/ssrModuleLoader.ts
@@ -228,7 +228,9 @@ async function nodeImport(
   // When an ESM module imports an ESM dependency, this hook is *not* used.
   const unhookNodeResolve = hookNodeResolve(
     (nodeResolve) => (id, parent, isMain, options) => {
-      if (id[0] === '.' || isBuiltin(id)) {
+      // Fix #5709, use require to resolve files with the '.node' file extension.
+      // See detail, https://nodejs.org/api/addons.html#addons_loading_addons_using_require
+      if (id[0] === '.' || isBuiltin(id) || id.endsWith('.node')) {
         return nodeResolve(id, parent, isMain, options)
       }
       if (parent) {