chore: more typecheck

package.json

@@ -17,7 +17,7 @@
     "postinstall": "simple-git-hooks",
     "format": "prettier --write --cache .",
     "lint": "eslint --cache .",
-    "typecheck": "tsc -p scripts --noEmit && tsc -p playground --noEmit && tsc -p packages/create-vite --noEmit",
+    "typecheck": "tsc -p scripts --noEmit && tsc -p playground --noEmit && tsc -p packages/create-vite --noEmit && tsc -p packages/vite/scripts --noEmit",
     "test": "run-s test-unit test-serve test-build",
     "test-serve": "vitest run -c vitest.config.e2e.ts",
     "test-build": "VITE_TEST_BUILD=1 vitest run -c vitest.config.e2e.ts",
@@ -81,7 +81,6 @@
     "resolve": "^1.22.1",
     "rimraf": "^3.0.2",
     "rollup": "^3.7.0",
-    "rollup-plugin-license": "^2.9.1",
     "semver": "^7.3.8",
     "simple-git-hooks": "^2.8.1",
     "tslib": "^2.4.1",

packages/create-vite/build.config.ts

@@ -3,7 +3,7 @@ import url from 'node:url'
 // eslint-disable-next-line node/no-extraneous-import
 import type { Plugin } from 'rollup'
 import { defineBuildConfig } from 'unbuild'
-import licensePlugin from '../../scripts/rollupLicensePlugin.mjs'
+import licensePlugin from '../vite/rollupLicensePlugin'
 
 const __dirname = path.dirname(url.fileURLToPath(import.meta.url))
 

packages/create-vite/tsconfig.json

@@ -6,7 +6,7 @@
     "module": "ES2020",
     "moduleResolution": "Node",
     "strict": true,
-    "allowJs": true,
+    "skipLibCheck": true,
     "declaration": false,
     "sourceMap": false,
     "noUnusedLocals": true,

packages/vite/package.json

@@ -111,6 +111,7 @@
     "postcss-load-config": "^4.0.1",
     "postcss-modules": "^6.0.0",
     "resolve.exports": "^1.1.0",
+    "rollup-plugin-license": "^2.9.1",
     "sirv": "^2.0.2",
     "source-map-js": "^1.0.2",
     "source-map-support": "^0.5.21",

packages/vite/rollup.config.ts

@@ -8,7 +8,7 @@ import json from '@rollup/plugin-json'
 import MagicString from 'magic-string'
 import type { Plugin, RollupOptions } from 'rollup'
 import { defineConfig } from 'rollup'
-import licensePlugin from '../../scripts/rollupLicensePlugin.mjs'
+import licensePlugin from './rollupLicensePlugin'
 
 const pkg = JSON.parse(
   readFileSync(new URL('./package.json', import.meta.url)).toString(),
@@ -78,7 +78,7 @@ function createNodePlugins(
   isProduction: boolean,
   sourceMap: boolean,
   declarationDir: string | false,
-): Plugin[] {
+): (Plugin | false)[] {
   return [
     nodeResolve({ preferBuiltins: true }),
     typescript({
@@ -284,7 +284,7 @@ const __require = require;
       if (!chunk.fileName.includes('chunks/dep-')) return
 
       const match = code.match(/^(?:import[\s\S]*?;\s*)+/)
-      const index = match ? match.index + match[0].length : 0
+      const index = match ? match.index! + match[0].length : 0
       const s = new MagicString(code)
       // inject after the last `import`
       s.appendRight(index, cjsPatch)

scripts/rollupLicensePlugin.mjs → packages/vite/rollupLicensePlugin.ts

@@ -1,28 +1,26 @@
-// @ts-check
-
 import fs from 'node:fs'
 import path from 'node:path'
 import license from 'rollup-plugin-license'
 import colors from 'picocolors'
 import fg from 'fast-glob'
 import resolve from 'resolve'
+import type { Plugin } from 'rollup'
 
-/**
- * @param {string} licenseFilePath
- * @param {string} licenseTitle
- * @param {string} packageName
- */
-function licensePlugin(licenseFilePath, licenseTitle, packageName) {
+export default function licensePlugin(
+  licenseFilePath: string,
+  licenseTitle: string,
+  packageName: string,
+): Plugin {
   return license({
     thirdParty(dependencies) {
       // https://github.com/rollup/rollup/blob/master/build-plugins/generate-license-file.js
       // MIT Licensed https://github.com/rollup/rollup/blob/master/LICENSE-CORE.md
       const coreLicense = fs.readFileSync(
-        new URL('../LICENSE', import.meta.url),
+        new URL('../../LICENSE', import.meta.url),
       )
-      function sortLicenses(licenses) {
-        let withParenthesis = []
-        let noParenthesis = []
+      function sortLicenses(licenses: Set<string>) {
+        let withParenthesis: string[] = []
+        let noParenthesis: string[] = []
         licenses.forEach((license) => {
           if (/^\(/.test(license)) {
             withParenthesis.push(license)
@@ -34,12 +32,10 @@ function licensePlugin(licenseFilePath, licenseTitle, packageName) {
         noParenthesis = noParenthesis.sort()
         return [...noParenthesis, ...withParenthesis]
       }
-      const licenses = new Set()
+      const licenses = new Set<string>()
       const dependencyLicenseTexts = dependencies
         .sort(({ name: _nameA }, { name: _nameB }) => {
-          const nameA = /** @type {string} */ (_nameA)
-          const nameB = /** @type {string} */ (_nameB)
-          return nameA > nameB ? 1 : nameB > nameA ? -1 : 0
+          return _nameA! > _nameB! ? 1 : _nameB! > _nameA! ? -1 : 0
         })
         .map(
           ({
@@ -96,7 +92,7 @@ function licensePlugin(licenseFilePath, licenseTitle, packageName) {
                   .join('\n') +
                 '\n'
             }
-            licenses.add(license)
+            licenses.add(license!)
             return text
           },
         )
@@ -122,5 +118,3 @@ function licensePlugin(licenseFilePath, licenseTitle, packageName) {
     },
   })
 }
-
-export default licensePlugin

packages/vite/tsconfig.json

@@ -1,7 +1,6 @@
 {
   "extends": "./tsconfig.base.json",
   "compilerOptions": {
-    "strict": false,
     "declaration": false,
     "resolveJsonModule": true
   },