chore: relocate to manifest only side-effects

vitejs · Sep 2, 2022 · 9f0ba41 · 9f0ba41
1 parent 7757787
commit 9f0ba41
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 6 deletions.
diff --git a/packages/vite/src/node/plugins/asset.ts b/packages/vite/src/node/plugins/asset.ts
@@ -21,13 +21,13 @@ import { FS_PREFIX } from '../constants'
 
 export const assetUrlRE = /__VITE_ASSET__([a-z\d]{8})__(?:\$_(.*?)__)?/g
 
+export const duplicateAssets: OutputAsset[] = []
+
 const rawRE = /(\?|&)raw(?:&|$)/
 const urlRE = /(\?|&)url(?:&|$)/
 
 const assetCache = new WeakMap<ResolvedConfig, Map<string, string>>()
 
-const duplicateAssets: OutputAsset[] = []
-
 const assetHashToFilenameMap = new WeakMap<
   ResolvedConfig,
   Map<string, string>
@@ -185,10 +185,6 @@ export function assetPlugin(config: ResolvedConfig): Plugin {
     },
 
     generateBundle(_, bundle) {
-      duplicateAssets.forEach((asset) => {
-        bundle[asset.name!] = asset
-      })
-
       // do not emit assets for SSR build
       if (config.command === 'build' && config.build.ssr) {
         for (const file in bundle) {

diff --git a/packages/vite/src/node/plugins/manifest.ts b/packages/vite/src/node/plugins/manifest.ts
@@ -4,6 +4,7 @@ import type { ResolvedConfig } from '..'
 import type { Plugin } from '../plugin'
 import { normalizePath } from '../utils'
 import { cssEntryFilesCache } from './css'
+import { duplicateAssets } from './asset'
 
 export type Manifest = Record<string, ManifestChunk>
 
@@ -16,6 +17,7 @@ export interface ManifestChunk {
   isDynamicEntry?: boolean
   imports?: string[]
   dynamicImports?: string[]
+  isDuplicate?: true
 }
 
 export function manifestPlugin(config: ResolvedConfig): Plugin {
@@ -122,6 +124,12 @@ export function manifestPlugin(config: ResolvedConfig): Plugin {
         }
       }
 
+      duplicateAssets.forEach((asset) => {
+        const chunk = createAsset(asset)
+        chunk.isDuplicate = true
+        manifest[asset.name!] = chunk
+      })
+
       outputCount++
       const output = config.build.rollupOptions?.output
       const outputLength = Array.isArray(output) ? output.length : 1