fix: define stubs for react-refresh in Web Worker #311
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes the issue below and improves #181.
Also the issue is mentioned in vitejs/vite#5396 (comment)
Define some stubs in Web Worker which is required by react-refresh to avoid the error:
Uncaught ReferenceError: $RefreshReg$ is not defined
.Issue
First, create Worker.tsx with the following content
Then, load Worker.tsx from App.tsx
In that case, we got the error below
Additional context
To avoid this error, @react-three/offscreen package, which renders React Three Fiber to OffscreenCanvas, shows the workaround to downgrade vite-plugin-react and disable all HMR.
This provides bad development experiences, so I hope that a new version will be released soon.
Reference:
https://github.com/pmndrs/react-three-offscreen?tab=readme-ov-file#vite
What is the purpose of this pull request?
Before submitting the PR, please make sure you do the following
fixes #123
).