Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: remove esbuild.logOverride['this-is-undefined-in-esm'] #134

Merged
merged 1 commit into from Mar 30, 2023

Conversation

sapphi-red
Copy link
Member

Description

We no longer need to set this because esbuild 0.15.8 changed this-is-undefined-in-esm to a debug log from a warning (evanw/esbuild@93e068d).

refs vitejs/vite#8674

Additional context


What is the purpose of this pull request?

  • Bug fix
  • New Feature
  • Documentation update
  • Other

Before submitting the PR, please make sure you do the following

  • Read the Contributing Guidelines.
  • Read the Pull Request Guidelines and follow the PR Title Convention.
  • Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
  • Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123).
  • Ideally, include relevant tests that fail without this PR but pass with it.

@ArnaudBarre ArnaudBarre merged commit ef10925 into main Mar 30, 2023
7 checks passed
@ArnaudBarre ArnaudBarre deleted the chore/remove-logoverride branch March 30, 2023 16:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants