Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: use Node.js 18 #156

Merged
merged 1 commit into from Nov 30, 2022
Merged

fix: use Node.js 18 #156

merged 1 commit into from Nov 30, 2022

Conversation

brillout
Copy link
Contributor

Using Node.js 18 instead of Node.js 16 should fix VPS's CI.

Also potentially the Laravel CI since its TS error is also about Node.js (CC @timacdonald).

Currently failing eco CI: vitejs/vite#11110 (comment)

@patak-dev
Copy link
Member

This sounds good to me, feel free to merge @dominikg

@dominikg
Copy link
Collaborator

are you sure this fixed it? afaik node18 is a bit slower than node16 and the executing runtime should not affect the ts types? or is your CI running exclusively in node18?

i changed the types/node override to only apply to vite-3 tests, #155 but maybe it needs to be removed altogether instead?

@brillout
Copy link
Contributor Author

Yes, in my case, that specific test is exclusively run with Node.js 18. This test uses res.writeEarlyHints() which was introduced in Node.js 18 so this PR should fix the problem (although I'm not sure whether #155 will interfere).

@dominikg dominikg merged commit 76dcce9 into vitejs:main Nov 30, 2022
@timacdonald
Copy link

Thanks for the ping. I think the issue our package was hitting in the Vite CI pipeline was related to this fix: #154

We had to update these types in our package locally because they started conflicting with a recent TS version.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants