Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: use createRequire to load rollup replace plugin #406

Merged
merged 3 commits into from Nov 7, 2022
Merged

fix: use createRequire to load rollup replace plugin #406

Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
f9d4db2
fix: use `createRequire` to load rollup replace plugin
userquin Nov 4, 2022
5ad1ede
chore: rename `require` to `nodeRequire`
userquin Nov 4, 2022
155bf63
chore: rollup replace as dependency
userquin Nov 7, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
16 changes: 14 additions & 2 deletions src/modules.ts
View file
Open in desktop
Expand Up @@ -25,6 +25,19 @@ async function loadWorkboxBuild(): Promise<typeof import('workbox-build')> {
}
}

async function loadRollupReplacePlugin() {
// Uses require to lazy load.

try {
const { createRequire } = await import('module').then(m => m.default || m)
const nodeRequire = createRequire(_dirname)
return nodeRequire('@rollup/plugin-replace')
}
catch (_) {
return require('@rollup/plugin-replace')
}
}

export async function generateRegisterSW(options: ResolvedVitePWAOptions, mode: 'build' | 'dev', source = 'register') {
const sw = options.base + options.filename
const scope = options.scope
Expand Down Expand Up @@ -98,7 +111,7 @@ export async function generateInjectManifest(options: ResolvedVitePWAOptions, vi
if (includedPluginNames.length === 0)
includedPluginNames.push(...defaultInjectManifestVitePlugins)

const { default: replace } = await import('@rollup/plugin-replace')
const replace = await loadRollupReplacePlugin()

const plugins = [
replace({
Expand All @@ -110,7 +123,6 @@ export async function generateInjectManifest(options: ResolvedVitePWAOptions, vi
const { rollup } = await import('rollup')
const bundle = await rollup({
input: options.swSrc,
// @ts-expect-error Vite and Rollup plugin shouldn't be aligned?
plugins,
})
try {
Expand Down