Remove reflections

[hoangmaihuy]

Changes being made

Remove reflections from dependencies. I've made changes in two places:

• ClassTagUtils: Simply replace reflections usage with Java's reflection methods
• ScalapbPayloadConverter: reflections is being used for scanning Scalapb's companion objects, but instead we can get companion object from valueClass.

Additional context

reflections is not under active development and maintenance, and it has serveral issues on newer JDKs, please see ronmamo/reflections#440 and ronmamo/reflections#377 for example.

[vitaliihonta]

Hi @hoangmaihuy! Thank you so much for your contribution! That's a very clever change. I didn't expect it's that straightforward to drop reflections 😄
Before merging, I will check if everything works fine in my example projects. I hope to do it soon

[vitaliihonta]

I found some issues while decoding ADTs. I will figure it out on my own 😃

[hoangmaihuy]

@vitaliihonta Thank you a lot for this great work, glad I can help! 😄

[vitaliihonta]

TODOs

• Check if the default ScalaPB generated oneOf's work work
• Develop a workaround for classes generated using sealedValue

[hoangmaihuy]

@vitaliihonta Workaround for sealedValue might be like this, I've tested on my local and it worked!
Please let me know if it works on your example projects

  private def getClassCompanion[T](
    valueClass: Class[T]
  ): GeneratedMessageCompanion[GeneratedMessage] = {
    val companionClass = Class.forName(valueClass.getName + "$")
    companionClass
      .getDeclaredField(scalaModuleField)
      .get(null)
      .asInstanceOf[GeneratedMessageCompanion[GeneratedMessage]]
  }

  private def getCompanion[T](
    typeUrl: String,
    valueClass: Class[T]
  ): GeneratedMessageCompanion[GeneratedMessage] = {
    println(s"typeUrl = $typeUrl")
    println(s"valueClass = ${valueClass.getName}")
    if (valueClass.isInterface && valueClass.getInterfaces.contains(classOf[GeneratedSealedOneof])) {
      val subClassType = typeUrl.split("\\.").last
      val subClassName = valueClass.getName.replace(valueClass.getSimpleName, subClassType)
      println(s"subClassName = ${subClassName}")
      getClassCompanion(Class.forName(subClassName))
    } else {
      getClassCompanion(valueClass)
    }
  }

[vitaliihonta]

Hey @hoangmaihuy, could you merge my updates from #120 into your branch? I cannot push my changes to your fork directly, but I want to keep you in the commit history 😃

Your solution works perfectly! I just had to adapt it for some internal corner cases

[hoangmaihuy]

@vitaliihonta I've merged #120 into this branch 😄

[codecov-commenter]

Codecov Report

Merging #117 (1b954c3) into main (0b8b0dd) will decrease coverage by 0.63%.
The diff coverage is 87.50%.

@@            Coverage Diff             @@
##             main     #117      +/-   ##
==========================================
- Coverage   39.05%   38.43%   -0.63%     
==========================================
  Files         116      115       -1     
  Lines        4127     4046      -81     
==========================================
- Hits         1612     1555      -57     
+ Misses       2515     2491      -24     

Files Changed	Coverage Δ
.../zio/temporal/protobuf/ProtobufDataConverter.scala	0.00% <0.00%> (ø)
...in/scala/zio/temporal/internal/ClassTagUtils.scala	77.14% <83.33%> (+8.09%)	⬆️
...io/temporal/protobuf/ScalapbPayloadConverter.scala	90.83% <92.50%> (-2.56%)	⬇️

... and 6 files with indirect coverage changes

[vitaliihonta]

@hoangmaihuy, thank you so much for your contribution 🙌
I'm going to release it in 0.5.0 as makeAutoload method was removed