chore: Update packages #1119
Merged
chore: Update packages #1119
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
bprusinowski
force-pushed
the
perf/general-optimizations
branch
from
4e29cb3
to
d1fcfd1
Compare
bprusinowski
force-pushed
the
perf/general-optimizations
branch
from
d1fcfd1
to
b76e07f
Compare
bprusinowski
force-pushed
the
perf/general-optimizations
branch
from
b76e07f
to
4e3c40e
Compare
bprusinowski
force-pushed
the
perf/general-optimizations
branch
from
4e3c40e
to
c05f9a3
Compare
…ization-tool into perf/general-optimizations
bprusinowski
force-pushed
the
perf/general-optimizations
branch
from
c05f9a3
to
f84a8d2
Compare
ptbrowne
approved these changes
Aug 28, 2023
...as we anyway track the performance of GQL queries ourselves, and this feature was breaking the Keycloak login.
bprusinowski
force-pushed
the
perf/general-optimizations
branch
from
e139e3c
to
abad759
Compare
bprusinowski
force-pushed
the
perf/general-optimizations
branch
from
f7546cf
to
dca6a71
Compare
bprusinowski
force-pushed
the
perf/general-optimizations
branch
from
dca6a71
to
1862e08
Compare
...to support React 18.
...to avoid being displayed on top when BrowseStateProvider is being updated.
...to support React 18.
...so it works with React 18.
...so libraries that reference the newest version with "*" can still be typed correctly, even if they weren't migrated to React 18.
…ng React 18 to still work ...mostly by allowing FC components to accept children prop.
…into perf/general-optimizations
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1048.
This PR is the first step towards updating the apps' packages to recent versions. This might be necessary, as some of the versions we use are four years old, and we need to update them to e.g. make sure our Vercel deployments still run (Node 18).
It might also bring us some performance improvements, assuming that the packages we use were also optimised along the way.
For more information, see the internal migration plan.
Node.jsfrom v16 to v18Next.jsfrom v11 to v13Reactfrom v17 to v18next-authfrom v4.10 to v4.23apollo-server-microfrom v2 to v3React 18 changed the way the functional components are typed – now it's necessary to explicitly type children prop. As some of the libraries we use (e.g.
react-beautiful-dnd) have not upgraded the type definitions to update types, we could either:resolutionin package.json and keep the new types indevDependencies(which results in an error when installing the dependencies with--frozen-lockfile),devDependencies,After looking at the breaking type updates, I think we could stick to older types for the time being, and potentially replace unsupported libraries over the time.