chore(loader-utils): Example working on range requests #2966
Conversation
| // loaders.gl | ||
| // SPDX-License-Identifier: MIT | ||
| // Copyright (c) vis.gl contributors | ||
| import {FileProvider} from './file-provider'; |
There was a problem hiding this comment.
Check differences with HTTPFile (which does inherit from ReadableFil):
We should really have some tests for this. Maybe we can mock fetch?
| * @param lenght Length of read data | ||
| */ | ||
| private async getBytesFromFile(start: number, lenght: number): Promise<ArrayBuffer> { | ||
| const res = await fetch(this.url, { |
There was a problem hiding this comment.
My worry with FileProvider is that makes lots of tiny reads - that will absolutely kill performance for anything network based.
| height: 100%; | ||
| } | ||
|
|
||
| body { |
There was a problem hiding this comment.
Do we need so much styling. The smaller we make the example source files, the better.
| "maplibre-gl": "^3.6.2", | ||
| "prop-types": "^15.7.2", | ||
| "react": "^18.2.0", | ||
| "react-color": "^2.19.3", |
There was a problem hiding this comment.
Are all dependencies used? Again try to minimize.
| import {Tile3DLayer, Tile3DLayerProps} from '@deck.gl/geo-layers'; | ||
| import {UpdateParameters} from '@deck.gl/core/typed'; | ||
|
|
||
| export default class CustomTile3DLayer< |
There was a problem hiding this comment.
Please add comments explaining what this custom layer does, why we needed to subclass it. The switch to range requests should ideally not require any changes to the layer?
| @@ -21,39 +21,39 @@ export class BrowserFile implements FileProvider { | |||
| * @param lenght Length of read data | |||
| */ | |||
| private async getBytesFromFile(start: number, lenght: number): Promise<ArrayBuffer> { | |||
| let reader = new FileReader(); | |||
| const reader = new FileReader(); | |||
There was a problem hiding this comment.
- We already have blob-file.ts that handles this.
- AFAIK, there is no advantage to use FileReader over
await Blob.arrayBuffer();
| worker: false | ||
| }; | ||
| // @ts-expect-error | ||
| const layers = new CustomTile3DLayer({ |
There was a problem hiding this comment.
| const layers = new CustomTile3DLayer({ | |
| const layer = new CustomTile3DLayer({ |
I added there main mechanism for loading slpk via range requests. Optimisation will be implemented in the future PRs so it works only on relatively small datasets for now.