-
Notifications
You must be signed in to change notification settings - Fork 184
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
parquet: slightly simpler arrow api #2279
Conversation
…orkers. (#2276) Co-authored-by: Victor Belomestnov <belom88@yandex.ru>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Either way this does require a potentially enormous table to be fully materialized in memory as opposed to streaming it out.
@trxcllnt may have some thoughts.
Yeah. There are two issues around memory copies.
|
0bfc693
to
9121963
Compare
210fc32
to
6fbf2d0
Compare
1656ac2
to
b822caa
Compare
I saw #2276 and thought I should adapt the code to use the upstream
tableFromIPC
andtableToIPC
while I'm thinking about it