Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Domain server first time wizard improvements and fixes. #1603

Merged
merged 16 commits into from Feb 26, 2022

Conversation

namark
Copy link
Contributor

@namark namark commented Feb 17, 2022

Resolves #1551 and #1419
Includes the relevant dependable PRs.

There are a few caveats with 1419. I tried to use quasars fixed positioning for the checkbox, but it wouldn't work no matter where I put it, so I eventually went with just basic css. I also had to dig into internals of vanta to implement pausing of the animation. I though to open a PR there, but not sure if the project is still alive, we might need to fork or completely replace it in the long term.

dependabot bot and others added 14 commits October 4, 2021 20:12
Bumps [axios](https://github.com/axios/axios) from 0.21.1 to 0.21.2.
- [Release notes](https://github.com/axios/axios/releases)
- [Changelog](https://github.com/axios/axios/blob/master/CHANGELOG.md)
- [Commits](axios/axios@v0.21.1...v0.21.2)

---
updated-dependencies:
- dependency-name: axios
  dependency-type: direct:production
...

Signed-off-by: dependabot[bot] <support@github.com>
Bumps [nth-check](https://github.com/fb55/nth-check) from 2.0.0 to 2.0.1.
- [Release notes](https://github.com/fb55/nth-check/releases)
- [Commits](fb55/nth-check@v2.0.0...v2.0.1)

---
updated-dependencies:
- dependency-name: nth-check
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <support@github.com>
Bumps [follow-redirects](https://github.com/follow-redirects/follow-redirects) from 1.14.3 to 1.14.7.
- [Release notes](https://github.com/follow-redirects/follow-redirects/releases)
- [Commits](follow-redirects/follow-redirects@v1.14.3...v1.14.7)

---
updated-dependencies:
- dependency-name: follow-redirects
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <support@github.com>
Bumps [nanoid](https://github.com/ai/nanoid) from 3.1.25 to 3.2.0.
- [Release notes](https://github.com/ai/nanoid/releases)
- [Changelog](https://github.com/ai/nanoid/blob/main/CHANGELOG.md)
- [Commits](ai/nanoid@3.1.25...3.2.0)

---
updated-dependencies:
- dependency-name: nanoid
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <support@github.com>
Bumps [three](https://github.com/mrdoob/three.js) from 0.132.2 to 0.137.0.
- [Release notes](https://github.com/mrdoob/three.js/releases)
- [Commits](https://github.com/mrdoob/three.js/commits)

---
updated-dependencies:
- dependency-name: three
  dependency-type: direct:production
...

Signed-off-by: dependabot[bot] <support@github.com>
…erver/resources/web/web-new/follow-redirects-1.14.7'
…erver/resources/web/web-new/nth-check-2.0.1'
Bumps [follow-redirects](https://github.com/follow-redirects/follow-redirects) from 1.14.3 to 1.14.8.
- [Release notes](https://github.com/follow-redirects/follow-redirects/releases)
- [Commits](follow-redirects/follow-redirects@v1.14.3...v1.14.8)

---
updated-dependencies:
- dependency-name: follow-redirects
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <support@github.com>
…erver/resources/web/web-new/follow-redirects-1.14.8' into domain-server-web-wizar-improvements
@digisomni digisomni linked an issue Feb 19, 2022 that may be closed by this pull request
@digisomni digisomni added CR Approved At least one code reviewer has approved the PR. and removed needs CR (code review) labels Feb 19, 2022
@digisomni
Copy link
Member

digisomni commented Feb 19, 2022

image

image

For some reason this is coming back in a stringified form now?

Happens when you connect your Domain to the metaverse.

@digisomni digisomni removed the CR Approved At least one code reviewer has approved the PR. label Feb 19, 2022
@digisomni digisomni self-requested a review February 19, 2022 22:25
@namark
Copy link
Contributor Author

namark commented Feb 19, 2022

Probably this issue axios/axios#4018, will try bumping axios version further I guess

@digisomni digisomni added the rebuild rebuild through the GithubActions label Feb 20, 2022
@digisomni digisomni changed the base branch from master to debug/memory-debugging February 21, 2022 22:38
@digisomni digisomni changed the base branch from debug/memory-debugging to master February 21, 2022 22:38
@digisomni digisomni added rebuild rebuild through the GithubActions and removed rebuild rebuild through the GithubActions labels Feb 21, 2022
@digisomni digisomni added rebuild rebuild through the GithubActions and removed rebuild rebuild through the GithubActions labels Feb 22, 2022
Copy link
Member

@digisomni digisomni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

2022.1.1 Selene Release automation moved this from In progress to Reviewer approved Feb 23, 2022
@digisomni digisomni added CR Approved At least one code reviewer has approved the PR. QA Approved The PR has been tested successfully. and removed needs testing (QA) The PR is ready for testing needs CR (code review) labels Feb 23, 2022
@digisomni digisomni merged commit 4c8593f into vircadia:master Feb 26, 2022
2022.1.1 Selene Release automation moved this from Reviewer approved to Done Feb 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CR Approved At least one code reviewer has approved the PR. domain-server Issues related to the domain server in general QA Approved The PR has been tested successfully. rebuild rebuild through the GithubActions
3 participants