Allow to specify a custom shepherd endpoint #9112
Conversation
|
ping @ngmy also. What do you think about these changes? |
|
Hey @orklah Do you know why circleci almost always fails with |
| } | ||
|
|
||
| return ''; | ||
| /** @psalm-suppress MixedAssignment */ |
There was a problem hiding this comment.
this method exist just to minimise possible BC (it's public static method :/ )
|
Can we make it so the current property doesn't change value and behaves like before until it's removed? I advised at least one person to change the value here and I wouldn't want to break that if it's not needed
Something is broken, it's not just a memory thing. As far as I can tell, it did not begin on a specific commit, rather at a specific time. Also the code we're analyzing did not change (we analyze a fork of phpunit). My best guess is that a compatibility layer was installed on a dependency of phpunit that makes Psalm think a class has been analyzed when it didn't. I can't find the time to debug that unfortunately |
asked by orklah, see vimeo#9112 (comment)
Yes, we can, but it requires to write high complexity code, but I can do that. Then, for Psalm 6, we need to cleanup this complexity and it's better to do it with this (create a new PR for Psalm 6, but I don't see a branch for it) UPD: done, I did my best, this is the weirdest peace of code I've written for latest few years, but it should work :). I would suggest to privatize more properties, classes to make such changes easier to change. By this moment a lot of Psalm code is a subject for breaking compatibility. |
…raits Support constants in traits
Allow sebastian/diff 5
Fix remaining ignored CallMap return types that can be updated
…ine_rules Report unused baseline entries
|
Seems good to merge, can you rebase to solve the conflict please? |
asked by orklah, see vimeo#9112 (comment)
…-endpoint' into allow-to-specify-custom-shepherd-endpoint # Conflicts: # psalm-baseline.xml
Currently it's possible to specify only a custom domain, so you have to use
hooks/psalm/route. In this PR I made it more flexible, so a user can specify any URL.Before this PR, it's possible to specify shepherd host using 2 ways (by priority):
--shepherdcli option. Without value it just a flag to send report to http://shepherd.dev. It's also possible to use it with value:--shepherd=custom.domainPSALM_SHEPHERDandPSALM_SHEPHERD_HOST. WherePSALM_SHEPHERDis a flag, usingPSALM_SHEPHERD_HOSTyou can specify a domain (introduced by Add the environment variable for using Shepherd #5512, shipped within 4.9.0)I think it will be nice to use a single env variable instead 2, as we do for cli option (for consistency). Also, any van names that includes "host" are not valid anymore as we can specify full URL/endpoint.