Json baseline formatter #8921
Closed
Json baseline formatter #8921
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jack-worman
force-pushed
the
json_baseline
branch
2 times, most recently
from
6383971
to
e6d6e39
Compare
What do you mean by that? Number of occurences is an important part of the baseline when there is no snippet to register, you can't just drop those? |
I removed the part of the code that didn't include the selection if it had a line break in it. So, the number of selections always equals occurrences. Are there other reasons for a selection to not be included? |
jack-worman
force-pushed
the
json_baseline
branch
from
e6d6e39
to
87b94d1
Compare
|
Closing in favor of #8967 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I just think JSON is much easier to read and work with.
And not including
occurrenceswill lead to smaller diffs, which is important for my team, as our baseline is constantly being updated.TODO: document new cli option