Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update PHPUnit #888

Merged
merged 5 commits into from Jul 13, 2018
Merged

Update PHPUnit #888

merged 5 commits into from Jul 13, 2018

Conversation

weirdan
Copy link
Collaborator

@weirdan weirdan commented Jul 13, 2018

This updates to PHPUnit 6/7, including the minor tweaks to the tests that were needed to satisfy Psalm and PHP for various PHP/PHPUnit combinations.

One Psalm failure is still there (PHP 7.0 / low-deps, https://travis-ci.com/weirdan/psalm/jobs/134301736#L855), but I hope it'll be fixed in phpunit (reported here: sebastianbergmann/phpunit#3209)

Nightly fails for unrelated reason (phpcs has some ugly switch/continue code).

Also it adds another variable into build matrix, causing travis to run with both lowest possible and highest possible dependencies. That's useful to see if your dependency version constraints actually make sense.

@muglug
Copy link
Collaborator

muglug commented Jul 13, 2018

I erroneously disabled coveralls on 7.2 when I added nightly, but it only needs to run on a single build. I've fixed that in master - could you rebase and remove coveralls from other PHP builds?

@weirdan
Copy link
Collaborator Author

weirdan commented Jul 13, 2018

I erroneously disabled coveralls on 7.2 when I added nightly, but it only needs to run on a single build

That's how it's already works in this PR, but I'll rebase to fix the conflicts. I'm going to mark 7.0/high as allowed_failure for the time being, until sebastianbergmann/phpunit#3209 is released in PHPUnit 6.5.10

@weirdan
Copy link
Collaborator Author

weirdan commented Jul 13, 2018

@muglug I got all green on builds here and on my own repo. Coveralls build has truncated output for vimeo/psalm build though.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.07%) to 86.633% when pulling 1e335fe on weirdan:update-phpunit into a8a504c on vimeo:master.

@weirdan
Copy link
Collaborator Author

weirdan commented Jul 13, 2018

Note that travis build matrix now uses exclude instead of include

@muglug muglug merged commit c1e21fc into vimeo:master Jul 13, 2018
@muglug
Copy link
Collaborator

muglug commented Jul 13, 2018

Thanks! Sorry for my confusion!

@weirdan weirdan deleted the update-phpunit branch July 13, 2018 21:52
@muglug
Copy link
Collaborator

muglug commented Jul 17, 2018

Also the test for low deps caught a bug with a new feature, thanks for that!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants