New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update PHPUnit #888
Update PHPUnit #888
Conversation
I erroneously disabled coveralls on 7.2 when I added nightly, but it only needs to run on a single build. I've fixed that in master - could you rebase and remove coveralls from other PHP builds? |
That's how it's already works in this PR, but I'll rebase to fix the conflicts. I'm going to mark 7.0/high as allowed_failure for the time being, until sebastianbergmann/phpunit#3209 is released in PHPUnit 6.5.10 |
Previous workaround was failing due to PHP warnings on 7.1 or 7.2 (depending on specific signature). There's just no signature that would be working for all 4 variants of (ver / dep) matrix.
@muglug I got all green on builds here and on my own repo. Coveralls build has truncated output for vimeo/psalm build though. |
Note that travis build matrix now uses exclude instead of include |
Thanks! Sorry for my confusion! |
Also the test for low deps caught a bug with a new feature, thanks for that! |
This updates to PHPUnit 6/7, including the minor tweaks to the tests that were needed to satisfy Psalm and PHP for various PHP/PHPUnit combinations.
One Psalm failure is still there (PHP 7.0 / low-deps, https://travis-ci.com/weirdan/psalm/jobs/134301736#L855), but I hope it'll be fixed in phpunit (reported here: sebastianbergmann/phpunit#3209)
Nightly fails for unrelated reason (phpcs has some ugly switch/continue code).
Also it adds another variable into build matrix, causing travis to run with both lowest possible and highest possible dependencies. That's useful to see if your dependency version constraints actually make sense.