Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow true in native types #8875

Merged
merged 1 commit into from Dec 10, 2022
Merged

Allow true in native types #8875

merged 1 commit into from Dec 10, 2022

Conversation

weirdan
Copy link
Collaborator

@weirdan weirdan commented Dec 10, 2022

Fixes #8872

For null and false, we already allowed them even as standalone
types, even though PHP before 8.2 only allowed them as part of a union.

Fixes vimeo#8872

For `null` and `false`, we already allowed them even as standalone
types, even though PHP before 8.2 only allowed them as part of a union.
@weirdan weirdan added the release:feature The PR will be included in 'Features' section of the release notes label Dec 10, 2022
@weirdan weirdan merged commit 16cdeb9 into vimeo:master Dec 10, 2022
@weirdan weirdan deleted the fix-8872 branch December 10, 2022 00:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release:feature The PR will be included in 'Features' section of the release notes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Return type true throws ReservedWord error in PHP 8.2
1 participant