New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix sealed combination #8798

Merged

orklah merged 2 commits into vimeo:master from orklah:min_count

Dec 1, 2022

Collaborator

orklah commented Nov 30, 2022

This will fix #8719

We were creating an non-empty-array based on the fact that there were sealed properties without actually checking if they could be undefined

@danog could you review that? Not sure if it was the best move here

orklah added 2 commits

November 30, 2022 23:26


          fix sealed array combination

3957eb7


          add test

2da4bf9

Collaborator

danog commented Dec 1, 2022 •

edited

LGTM!
The logic seems correct to me, even if I would've used a simple ! instead of !== true for readability :)

orklah added the release:fix label

orklah merged commit b4aa951 into vimeo:master

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment