Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Defer cache directory creation until it's needed #8789

Merged
merged 2 commits into from Nov 30, 2022
Merged

Defer cache directory creation until it's needed #8789

merged 2 commits into from Nov 30, 2022

Commits on Nov 29, 2022

  1. Defer cache directory creation until it's needed 

    Honestly, this is a bit of a hack, as we let `Config` to generate the
cache directory name and then reset it to null from the cli entrypoint.
Yet it's easier than passing a no-cache flag through so many layers of
static calls.

`$this->cache_directory_initialized` flag is used to make sure we
attempt to create the directory only once.

Fixes vimeo#4267
    @weirdan
    weirdan committed Nov 29, 2022
    Copy the full SHA
    6b3dd56 View commit details
    Browse the repository at this point in the history

  2. Document BC break

    @weirdan
    weirdan committed Nov 29, 2022
    Copy the full SHA
    6fd2ff1 View commit details
    Browse the repository at this point in the history