Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix XMLReader::expand() nullable parameter $baseNode #8641

Merged
merged 1 commit into from Nov 1, 2022
Merged

Fix XMLReader::expand() nullable parameter $baseNode #8641

merged 1 commit into from Nov 1, 2022

Conversation

BenMorel
Copy link
Contributor

@BenMorel BenMorel commented Nov 1, 2022

@BenMorel
Copy link
Contributor Author

BenMorel commented Nov 1, 2022

Not sure what to do with the failing tests, as they're all related to sqlsrv?

@orklah orklah added the release:fix The PR will be included in 'Fixes' section of the release notes label Nov 1, 2022
@orklah orklah merged commit 761d67f into vimeo:4.x Nov 1, 2022
@orklah
Copy link
Collaborator

orklah commented Nov 1, 2022 •
edited

Thanks! Failures are unrelated. They came at the same time as PHP 8.1.12, don't know why

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
release:fix The PR will be included in 'Fixes' section of the release notes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@BenMorel @orklah