Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add dictionary delta for PHP 8.2 #8634

Merged
merged 7 commits into from Oct 31, 2022
Merged

Add dictionary delta for PHP 8.2 #8634

merged 7 commits into from Oct 31, 2022

Conversation

alies-dev
Copy link
Contributor

@orklah
Copy link
Collaborator

orklah commented Oct 31, 2022

Thanks!

You'll have to change the target version here too:

private const PHP_MAJOR_VERSION = 8;

@alies-dev
Copy link
Contributor Author

@orklah

You'll have to change the target version here too:

thanks, done by 855eef9

@orklah
Copy link
Collaborator

orklah commented Oct 31, 2022

Cool!

there's a few tests failing it seems.

First, str_split, you changed its signature in 8.2 but didn't change it in Callmap.php, those two should match

Second, there's a bunch of errors seemingly coming from Reflection but I don't get it. Those are fine on other PR, you didn't touch those functions and the CI runs on 8.1 so Reflection has no way of inferring 8.2 types. (also, it doesn't seem to fail on Windows?!)

Could you try to take a look at what's going on? It comes from the testCallMapCompliesWithReflection test

@orklah
Copy link
Collaborator

orklah commented Oct 31, 2022

Oh, nvm, failures are reproduced on other PR, this is not related to yours

@orklah
Copy link
Collaborator

orklah commented Oct 31, 2022

Only the str_split one need to be fixed and I'll be able to merge :)

@alies-dev
Copy link
Contributor Author

@orklah

only the str_split one need to be fixed and I'll be able to merge :)

done by 9516bac ;)

Thanks for quick reviews!

@orklah orklah added the release:feature The PR will be included in 'Features' section of the release notes label Oct 31, 2022
@orklah orklah merged commit 3f0107e into vimeo:4.x Oct 31, 2022
@orklah
Copy link
Collaborator

orklah commented Oct 31, 2022

Thanks!

@alies-dev alies-dev deleted the php82 branch October 31, 2022 18:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release:feature The PR will be included in 'Features' section of the release notes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants