New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add dictionary delta for PHP 8.2 #8634
Conversation
Thanks! You'll have to change the target version here too:
|
Cool! there's a few tests failing it seems. First, str_split, you changed its signature in 8.2 but didn't change it in Callmap.php, those two should match Second, there's a bunch of errors seemingly coming from Reflection but I don't get it. Those are fine on other PR, you didn't touch those functions and the CI runs on 8.1 so Reflection has no way of inferring 8.2 types. (also, it doesn't seem to fail on Windows?!) Could you try to take a look at what's going on? It comes from the testCallMapCompliesWithReflection test |
Oh, nvm, failures are reproduced on other PR, this is not related to yours |
Only the str_split one need to be fixed and I'll be able to merge :) |
Thanks! |
Mostly bases on https://php.watch/versions/8.2