ensure callbacks have the required number of params #8594
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kkmuffme
force-pushed
the
callable-invalidargument-required-param-mismatch-missing-error
branch
from
25caba2
to
25b01ce
Compare
|
Ready to be reviewed & merged |
|
Can you add some tests to check how it reacts to variadics in callable's params and array destructuring on the call? |
kkmuffme
force-pushed
the
callable-invalidargument-required-param-mismatch-missing-error
branch
from
b789ce2
to
7d953df
Compare
|
Done |
orklah
added
the
release:fix
|
Thanks! |
kkmuffme
deleted the
callable-invalidargument-required-param-mismatch-missing-error
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #8593