New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add additional checks for concat of non-empty strings to return non-falsy #8585

Merged

orklah merged 2 commits into vimeo:4.x from gphargreaves:#8315/concat-non-empty-strings

Oct 15, 2022

Contributor

gphargreaves commented Oct 14, 2022 •

edited

Fixes #8315

This change adds some additional checks so:

Concat of two non-empty-string types returns a non-falsy-string
Concat of a non-empty-string and a numeric-string returns a non-falsy-string

Greg Hargreaves added 2 commits

October 14, 2022 01:54


          Add additional checks for concat of non-empty strings to return non-f…

06581ce

…alsy


          Remove duplicated numeric type declaration

b89ff32

orklah added the release:fix label

Collaborator

orklah commented Oct 15, 2022

Thanks!

orklah merged commit dbb8815 into vimeo:4.x

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment