Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update dictionaries for hash ext functions #8553

Merged
merged 6 commits into from
Oct 9, 2022
Merged

Update dictionaries for hash ext functions #8553

merged 6 commits into from
Oct 9, 2022

Conversation

alies-dev
Copy link
Contributor

@alies-dev alies-dev commented Oct 9, 2022

from the 8.0, hash() and hash_hmac() never return false; only hash_file() and
hash_hmac_file() return false in case the data cannot be read.

see cmb69/php-src@8982ef3 and php/php-src#7759

PHP 8.1 hash module function declarations: https://github.com/php/php-src/blob/php-8.1.11/ext/hash/hash.stub.php

@alies-dev alies-dev changed the title Update hash(), hash_file() and hash_init() types Update dictionaries for hash() functions Oct 9, 2022
@alies-dev alies-dev changed the title Update dictionaries for hash() functions Update dictionaries for hash module Oct 9, 2022
@alies-dev alies-dev changed the title Update dictionaries for hash module Update dictionaries for hash ext functions Oct 9, 2022
@orklah orklah added the release:fix The PR will be included in 'Fixes' section of the release notes label Oct 9, 2022
@orklah
Copy link
Collaborator

orklah commented Oct 9, 2022

Nice! Thanks!

@orklah orklah merged commit b424de9 into vimeo:4.x Oct 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release:fix The PR will be included in 'Fixes' section of the release notes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants