Add check for class const with reserved word 'class' #8542
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
orklah
reviewed
Oct 7, 2022
|
Looks good! Note that you targeted master, which is the branch for Psalm 5 which is scheduled for release in a few weeks if all works out. If you want to be sure to have this change on Psalm 4, you could target the 4.x branch, your choice :) |
orklah
added
the
release:feature
gphargreaves
force-pushed
the
class-constant-named-class
branch
from
b7b366a
to
41a6afd
Compare
|
LGTM, not sure what's up with CI though. I think I'd prefer this go in |
AndrolGenhald
approved these changes
Oct 7, 2022
|
Thanks! CI often go nuts when retargeting PRs, I think it reverts back to some old version of CI from somewhere |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
First contribution so hopefully my changes are in sensible places 馃榿 Addresses issue #8294
Had a read through the docs for the a structure of the analyzers and hopefully this change is fit for purpose, happy to tweak accordingly if you have any feedback.