Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

preg_replace with anchor will always only have 1 replacement #8469

Merged
merged 1 commit into from Sep 8, 2022
Merged

preg_replace with anchor will always only have 1 replacement #8469

merged 1 commit into from Sep 8, 2022

Conversation

kkmuffme
Copy link
Contributor

@kkmuffme kkmuffme commented Sep 8, 2022

  • add limit for clarity and performance
  • adjust where sub-optimal

@kkmuffme kkmuffme marked this pull request as ready for review September 8, 2022 17:22
@kkmuffme
Copy link
Contributor Author

kkmuffme commented Sep 8, 2022

Ready to be merged

@orklah orklah added the release:internal The PR will be included in 'Internal changes' section of the release notes label Sep 8, 2022
@orklah
Copy link
Collaborator

orklah commented Sep 8, 2022

Thanks!

@orklah orklah merged commit 76cfb91 into vimeo:4.x Sep 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
release:internal The PR will be included in 'Internal changes' section of the release notes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@kkmuffme @orklah