report invalidCasing when using a class that is not user defined too

[kkmuffme]

e.g. new DateTime

Fix #8456

[AndrolGenhald]

Please do NOT merge this yet

You can use drafts for that 🙂

Looks like it's already catching a couple of casing issues in the tests!

[kkmuffme]

You can use drafts for that 🙂

Thanks :-)

[kkmuffme]

Ready to be merged.

[AndrolGenhald]

I don't see this part, is it not necessary for some reason?

[kkmuffme]

This part is not strictly necessary for class casing check, but only for aliases. Also this requires a lot of other changes and it's a bitch to get working/correct with how cache handles this, so I will PR this separately, bc I don't know when I will have time to check it.

[AndrolGenhald]

@orklah it looks fine to me, but I don't know why internal classes were excluded in the first place, so that makes me a bit nervous just merging this without investigating that first.

[orklah]

@orklah it looks fine to me, but I don't know why internal classes were excluded in the first place, so that makes me a bit nervous just merging this without investigating that first.

I'm not surprised given how many errors it raises in Psalm itself. I'm not even sure the documentation was correct on older versions of PHP for things like DOMElement.

@kkuffme can you fix the remaining casing errors and it should be good to go

[AndrolGenhald]

I'm not surprised given how many errors it raises in Psalm itself.

I didn't even notice those 😆 I pay less attention to that now because I know it's been failing. We should really get that fixed soon...

[kkmuffme]

@orklah thanks, I didn't even notice them, as Shepherd awlays reports a false positive, so I tend not to check it anymore at all.

All fixed now.

vendor/nikic/php-parser/lib/PhpParser/Node/UnionType.php:18:24: InvalidPropertyAssignmentValue: $this->types with declared type 'array<array-key, PhpParser\Node\Identifier|PhpParser\Node\Name>' cannot be assigned type 'array<array-key, PhpParser\Node\Identifier|PhpParser\Node\IntersectionType|PhpParser\Node\Name>' (see https://psalm.dev/145)

This is not from this branch, this is an issue created somewhere else/exists on 4.x branch already.

[AndrolGenhald]

What about:

src/Psalm/Config.php:755:18: UnnecessaryVarAnnotation: The @var DOMElement|null annotation for $psalm_node is unnecessary

Why is that showing up now? Did the incorrect casing cause the redundancy to be missed? If so maybe we should also open an issue to fix UnnecessaryVarAnnotation to ignore casing.

[kkmuffme]

Yes, that's new now, fixed it.

There might be an issue there, I will check https://psalm.dev/r/84fbd22c02 once this PR is merged and open a separate issue for it if necessary.

[psalm-github-bot]

I found these snippets:

https://psalm.dev/r/84fbd22c02

<?php

use dateTime;

/**
 * @param dAteTime $arg
 * @return void
 */
function a( $arg ) {
	/** @var daTeTime $arg */
    echo $arg->format('Y-m-d H:i:s');
}

Psalm output (using commit afe85fa):

ERROR: UnnecessaryVarAnnotation - 10:11 - The @var dateTime annotation for $arg is unnecessary

[AndrolGenhald]

Hmm, that one already shows an error though. It's weird that fixing the casing on DOMElement would cause that UnnecessaryVarAnnotation to show up if it already shows up for other stuff with incorrect casing.

[kkmuffme]

I'm not sure what's happening there, but it's unrelated to this PR but a separate issue. It would be much easier to tackle this on a separate PR though, if there is an issue.

[orklah]

Thanks! Let's fix the unnecessary var in another PR indeed