Make ctype_digit and ctype_lower work as assertions #8450
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks like that code style test fails isn't my fault :) |
orklah
added
the
release:feature
|
Thanks!
Interesting, we should consider updating the callmap to reflect this from 8.1. It would prepare people to stop sending anything else than strings in there |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make
ctype_digitassert fornumeric-string, andctype_lowerfornon-empty-lowercase-string.I've implemented it as @orklah advised it here, but I've added two skipped tests that would fail with this naive implementation. It can be ignored though, because passing
ints toctype_*functions was deprecated in PHP 8.1.