Update call maps for MongoDB extension #8432
Conversation
orklah
added
the
release:feature
|
Thanks! Can you look at the mismatch reported in Unit Tests 4? |
alcaeus
force-pushed
the
mongodb-stub-corrections
branch
from
b8f65a6
to
b521488
Compare
|
Ah, there were some more (lowercased) entries in a completely separate portion of the file. These were now duplicated, but since they were originally lowercased they were treated as different. I removed the obsolete definitions. |
alcaeus
force-pushed
the
mongodb-stub-corrections
branch
from
b521488
to
6a6922d
Compare
|
I noticed that some of the interface declarations aren't correct. Please hold off on merging while I figure out where the script failed (probably has to do with tentative return types). |
That's fixed now. I didn't consider tentative return types for interfaces. |
| 'MongoDB\BSON\Decimal128::__construct' => ['void', 'value='=>'string'], | ||
| 'MongoDB\BSON\Binary::__toString' => ['string'], | ||
| 'MongoDB\BSON\Binary::serialize' => ['string'], | ||
| 'MongoDB\BSON\Binary::unserialize' => ['void', 'serialized' => ''], |
There was a problem hiding this comment.
serialized should have a type here, either mixed or more narrow
There was a problem hiding this comment.
Ah, thanks. Added the correct string type for all unserialize methods.
There was a problem hiding this comment.
I don't see a new commit on the branch? Forgot to push?
There was a problem hiding this comment.
Whopsie, yes. I pushed the commit now.
There was a problem hiding this comment.
Well, I have bad news then, I still don't see anything
There was a problem hiding this comment.
nvm, I was mistaken apparently
| 'MongoDB\BSON\BinaryInterface::__toString' => ['string'], | ||
| 'MongoDB\BSON\DBPointer::__toString' => ['string'], | ||
| 'MongoDB\BSON\DBPointer::serialize' => ['string'], | ||
| 'MongoDB\BSON\DBPointer::unserialize' => ['void', 'serialized' => ''], |
|
Thanks! |
While adding psalm checks to the MongoDB driver, I noticed that a number of method signatures in the call map were either missing or out-of-date. This PR updates them to what we'll ship in 1.15. They have been automatically generated from the definitions in the driver and made to match the format required by Psalm.