Allow any attribute for complex types in schema #8428
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Ah, i see this bug already fixed in psalm 5 same way, can we just bring full support of xinclude in 4.x? |
|
Really need |
|
@orklah can you review this pr? |
orklah
added
the
release:feature
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I think we can use full power of XInclude and allow any attribute with
laxorskipvalue inprocessContentsattribute. This gives more flexibility of building dynamic configs.For example, with current schema i can't use XInclude for issueHandlers configuration, because it has "anyAttribute" configuration, but without
processContents="lax"orprocessContents="skip"attribute. This PR solves this problem and other problems like this