Fix DatePeriod tests for implementing IteratorAggregate #8422
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I wrote them in a wrong way in vimeo#8312, so they are rewritten now as @AndrolGenhald advised in vimeo#8327
|
I was thinking it should be in providerInvalidCodeParse to make sure it has an error, if that test is working fine then it does seem like something is broken. |
I've tried it like that, it yields no error. I mean the test fails with the reason "No CodeException was thrown" or something. So Psalm thinks this code is valid in PHP 7.3 environment. |
|
4.x branch is closed now as we prepare for the 5.0 release. Please target the master branch instead. |
|
Closing as this targets 4.x which is closed. Please reopen on master going forward |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I wrote them in a wrong way in #8312, so they are rewritten now as @AndrolGenhald advised in #8327.
But actually I'm quite surprised Psalm allows me to call
getIterator()on a pure Traversable. It actually results in Fatal Error: https://3v4l.org/MEpb3 (But it's the only one way I've found to test it.)Looks like PHP 8 stubs indeed leaks to PHP 7 environment somehow.