Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Consistent error logging for cache #8415

Merged
merged 5 commits into from Sep 11, 2022
Merged

Consistent error logging for cache #8415

merged 5 commits into from Sep 11, 2022

Commits on Sep 11, 2022

  1. use exceptions instead of error_log for ParserCacheProvider 

    * use exceptions instead of error_log for ParserCacheProvider like all other cache providers do
* remove duplicate code in ParserCacheProvider
* use same hash as other cache providers
* update Config.php cache directory creation to use same code as ParserCacheProvider
    @kkmuffme
    kkmuffme committed Sep 11, 2022
    Configuration menu
    Copy the full SHA
    8da5f5e View commit details
    Browse the repository at this point in the history

  2. update leftover md5 in provider to commonly used hash 

    Revert "update leftover md5 in provider to commonly used hash"

This reverts commit 66337ec.

partially put back

Update StatementsProvider.php
    @kkmuffme
    kkmuffme committed Sep 11, 2022
    Configuration menu
    Copy the full SHA
    4726454 View commit details
    Browse the repository at this point in the history

  3. use consistent race condition dir creation code in all places in cache

    @kkmuffme
    kkmuffme committed Sep 11, 2022
    Configuration menu
    Copy the full SHA
    8ac86f0 View commit details
    Browse the repository at this point in the history

  4. improve unlinking potential race condition 

    * fix rare race condition on file cache unlink
* remove unnecessary reset()
* improve code readability using variable
    @kkmuffme
    kkmuffme committed Sep 11, 2022
    Configuration menu
    Copy the full SHA
    978f37e View commit details
    Browse the repository at this point in the history

  5. fix test cache inconsistency

    @kkmuffme
    kkmuffme committed Sep 11, 2022
    Configuration menu
    Copy the full SHA
    62df25a View commit details
    Browse the repository at this point in the history