Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix imageinterlace function signature #8403

Merged
merged 1 commit into from Aug 12, 2022
Merged

Fix imageinterlace function signature #8403

merged 1 commit into from Aug 12, 2022

Conversation

paulfedorow
Copy link
Contributor

@paulfedorow paulfedorow commented Aug 12, 2022 •
edited

This PR fixes the function signature of imageinterlace:

  • The return type is bool since PHP 8.0.5.
  • The type of the parameter enable is bool|null since PHP 8.0.0.

@orklah orklah added the release:fix The PR will be included in 'Fixes' section of the release notes label Aug 12, 2022
@orklah
Copy link
Collaborator

orklah commented Aug 12, 2022

Thanks!

@orklah orklah merged commit 24b8b8e into vimeo:4.x Aug 12, 2022
@paulfedorow paulfedorow deleted the imageinterlace-callmap-fix-4.x branch August 16, 2022 06:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
release:fix The PR will be included in 'Fixes' section of the release notes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@paulfedorow @orklah