Use classlike_storage_provider only if it has the required data

[Daeroni]

Fixes #8373

[AndrolGenhald]

Could you add a test to ensure this continues working in the future? Probably add something in AssertAnnotationTest.

[Daeroni]

It seems the bug requires the @psalm-assert annotation to be in a file that is not being analyzed (eg. library code from vendor-dir) but is included by the code being analyzed.

I tried to write a separate test method that adds to files to the scanner with addFilesToShallowScan and then just call addFilesToAnalyze to the file that is being tested (somewhat copied from the IncludeTest), but was unable to trigger the error.

I also tried to make a test project using the same package and similar code that our project has that triggers this error, but I couldn't reproduce it.

[AndrolGenhald]

How about this? Maybe add that to ClassTemplateTest.php?

[psalm-github-bot]

I found these snippets:

https://psalm.dev/r/cce84834fa

<?php

/**
 * @psalm-suppress UndefinedDocblockClass
 *
 * @param DoesNotExist<int> $baz
 */
function foobar(DoesNotExist $baz): void {}

/**
 * @psalm-suppress UndefinedDocblockClass, UndefinedClass
 * @var DoesNotExist
 */
$baz = new DoesNotExist();
foobar($baz);

Psalm encountered an internal error:

/vendor/vimeo/psalm/src/Psalm/Internal/Provider/ClassLikeStorageProvider.php: Could not get class storage for doesnotexist

[Daeroni]

@AndrolGenhald Thanks, that seems to work.

[AndrolGenhald]

Thanks!