always use lock when writing/reading cache data to/from file #8372
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kkmuffme
force-pushed
the
safely-read-write-cache-data
branch
3 times, most recently
from
fd76799
to
1a94fe2
Compare
|
Code review please |
|
Could we move the method to somewhere common so we could have only one? |
|
Yes, if you tell me where you want it :-) Also which exception do you want then? |
|
Providers.php seems fine For the exception, maybe RuntimeException? |
kkmuffme
force-pushed
the
safely-read-write-cache-data
branch
from
1a94fe2
to
8ca594a
Compare
|
Done, ready for review again. There's an internal error with CircleCI that's not from this branch, which is why the test fails: |
orklah
added
the
release:internal
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ran into igbinary end-of-data race condition with PHP 8.1 in a multi-threaded environment in some cases where the file was modified during reading
I just used
UnexpectedValueExceptionas that is what was there already in one case. If you prefer another exception, please let me know.