Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix invalid casts int and float #8366

Merged
merged 10 commits into from Sep 20, 2022
Merged

Fix invalid casts int and float #8366

merged 10 commits into from Sep 20, 2022

Commits on Sep 19, 2022

  1. fix type for (string) true

    @kkmuffme
    kkmuffme committed Sep 19, 2022
    Configuration menu
    Copy the full SHA
    e4b7cdf View commit details
    Browse the repository at this point in the history

  2. fix invalid casts for int 

    https://psalm.dev/r/0d284c6f48
    @kkmuffme
    kkmuffme committed Sep 19, 2022
    Configuration menu
    Copy the full SHA
    3bec76a View commit details
    Browse the repository at this point in the history

  3. same for float

    @kkmuffme
    kkmuffme committed Sep 19, 2022
    Configuration menu
    Copy the full SHA
    39ec755 View commit details
    Browse the repository at this point in the history

  4. float/int always 1 on "error", no PossiblyInvalidCasts by default

    @kkmuffme
    kkmuffme committed Sep 19, 2022
    Configuration menu
    Copy the full SHA
    d32efb0 View commit details
    Browse the repository at this point in the history

  5. be less strict for generic string type

    @kkmuffme
    kkmuffme committed Sep 19, 2022
    Configuration menu
    Copy the full SHA
    c3eebe2 View commit details
    Browse the repository at this point in the history

  6. add RiskyCast

    @kkmuffme
    kkmuffme committed Sep 19, 2022
    Configuration menu
    Copy the full SHA
    7cdad99 View commit details
    Browse the repository at this point in the history

  7. fix psalm-internal risky casts

    @kkmuffme
    kkmuffme committed Sep 19, 2022
    Configuration menu
    Copy the full SHA
    da68e9d View commit details
    Browse the repository at this point in the history

  8. Cherry-pick: Try to provide literal int types when possible (fixes vi… 

    …meo#6966) (vimeo#7071)

* Fixed vimeo#6966

* Only accept >= 0 values for mode argument in round()

* Made round() only return float or literal float values and remove unneeded test

* Registered RoundReturnTypeProvider

* Updated cast analyzer to handle single string literal int values as literal ints

* Fixed psalm errors

* Fix invalid property accesses

* Addressed comments

* Added Tests

* Marked RoundReturnTypeProvider as internal

* Fixed CS
    @ricardoboss @kkmuffme
    ricardoboss authored and kkmuffme committed Sep 19, 2022
    Configuration menu
    Copy the full SHA
    bf1c032 View commit details
    Browse the repository at this point in the history

  9. objects even with __toString methods cannot be cast to int/float

    @kkmuffme
    kkmuffme committed Sep 19, 2022
    Configuration menu
    Copy the full SHA
    d69be4b View commit details
    Browse the repository at this point in the history

Commits on Sep 20, 2022

  1. add RiskyCast tests

    @kkmuffme
    kkmuffme committed Sep 20, 2022
    Configuration menu
    Copy the full SHA
    d69e062 View commit details
    Browse the repository at this point in the history