Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Precise stat return type #8032

Merged
merged 2 commits into from May 30, 2022
Merged

Precise stat return type #8032

merged 2 commits into from May 30, 2022

Conversation

VincentLanglet
Copy link
Contributor

From https://www.php.net/manual/fr/function.stat.php

See also phpstan/phpstan-src#996

I basically copied the types from phpstan.

@VincentLanglet
Copy link
Contributor Author

Hi @orklah, i'm not against some help because I don't understand the failures :s

@orklah
Copy link
Collaborator

orklah commented May 29, 2022

You can ignore parse errors, seems like it's on our side. However, there are failing tests because you only updated Callmap.php. This file contains the most up-to-date information for the current tracked version(8.1), but it should always match with the file that introduced that definition. (For example, if a function was created in 7.4, you should add it in Callmap.php and Callmap74.php).

In your case, I think those function always existed and returned about the same thing, so you need to update Callmap_historical too

@weirdan weirdan added the release:fix The PR will be included in 'Fixes' section of the release notes label May 29, 2022
@VincentLanglet
Copy link
Contributor Author

In your case, I think those function always existed and returned about the same thing, so you need to update Callmap_historical too

Done :)

@orklah
Copy link
Collaborator

orklah commented May 30, 2022

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release:fix The PR will be included in 'Fixes' section of the release notes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants