Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Further improve Throwable::getTrace() return type #7864

Merged
merged 1 commit into from Apr 12, 2022
Merged

Further improve Throwable::getTrace() return type #7864

merged 1 commit into from Apr 12, 2022

Conversation

hirokinoue
Copy link
Contributor

Fixes #7830

Hi, I'm new to psalm. Any advice is welcome. Thanks in advance.

@orklah orklah added the release:fix The PR will be included in 'Fixes' section of the release notes label Apr 12, 2022
@orklah
Copy link
Collaborator

orklah commented Apr 12, 2022

Thanks! This looks great!

@orklah orklah merged commit f04945c into vimeo:4.x Apr 12, 2022
@hirokinoue hirokinoue deleted the precise-get-trace branch April 20, 2022 03:20
@vudaltsov
Copy link
Contributor

Hi! @hirokinoue, when keys file and line can be absent?

@hirokinoue
Copy link
Contributor Author

Hi, @vudaltsov. I guess the conversation meet your interest. I fixed the codes according to these comments.

@vudaltsov
Copy link
Contributor

@hirokinoue , thank you! Read and learned a lot!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
release:fix The PR will be included in 'Fixes' section of the release notes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Further improve Throwable::getTrace() return type
3 participants
@hirokinoue @orklah @vudaltsov