Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Throw exception if file_put_contents failed #7690

Merged
merged 2 commits into from Feb 18, 2022

Conversation

dmitryuk
Copy link

If psalm.xml is not writable, commands vendor/bin/psalm-plugin enable|disable %some_plugin will always response

 [OK] Plugin enabled 

with warning:

Warning: file_put_contents(/var/www/psalm.xml): Failed to open stream: Permission denied in /var/www/vendor/vimeo/psalm/src/Psalm/Internal/PluginManager/ConfigFile.php on line 146

For disabled warnings (error_reporting=E_ERROR) a coder will success without writing the result.
The PR throws an exceptions this case

@weirdan weirdan added the release:fix The PR will be included in 'Fixes' section of the release notes label Feb 18, 2022
@weirdan weirdan merged commit d8bec4c into vimeo:4.x Feb 18, 2022
@weirdan
Copy link
Collaborator

weirdan commented Feb 18, 2022

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release:fix The PR will be included in 'Fixes' section of the release notes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants