Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add phpredis stubs #7614

Merged
merged 2 commits into from Feb 11, 2022
Merged

add phpredis stubs #7614

merged 2 commits into from Feb 11, 2022

Conversation

kkmuffme
Copy link
Contributor

@kkmuffme kkmuffme commented Feb 9, 2022

Fixes #7581

Source: https://github.com/phpredis/phpredis/blob/e93be87023fffbf9213e8f47066f6dd646d8ba5a/redis.stub.php
=> these are not fully correct though (return types are partly wrong, params are partly wrong).

However there is a pending PR with correct stubs by the phpredis maintainer with correct stubs:
phpredis/phpredis#2015
So I used the stubs from that PR as they are correct: https://github.com/phpredis/phpredis/blob/e93be87023fffbf9213e8f47066f6dd646d8ba5a/redis.stub.php

@AndrolGenhald
Copy link
Collaborator

For 4.x you'll have to add an extension_loaded check around here so that the stub is actually used.

@kkmuffme
Copy link
Contributor Author

kkmuffme commented Feb 9, 2022

Thanks, added now.

@orklah orklah added the release:feature The PR will be included in 'Features' section of the release notes label Feb 9, 2022
@orklah orklah merged commit c13a536 into vimeo:4.x Feb 11, 2022
@orklah
Copy link
Collaborator

orklah commented Feb 11, 2022

Thanks!

@kkmuffme kkmuffme deleted the add-phpredis-stubs branch May 28, 2022 22:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release:feature The PR will be included in 'Features' section of the release notes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

phpredis stubs wrong again?
3 participants