Fix object constant inference #7542
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
orklah
reviewed
Jan 31, 2022
| @@ -55,7 +55,8 @@ public static function infer( | |||
| Aliases $aliases, | |||
| FileSource $file_source = null, | |||
| ?array $existing_class_constants = null, | |||
| ?string $fq_classlike_name = null | |||
| ?string $fq_classlike_name = null, | |||
| bool $const_inference = false | |||
There was a problem hiding this comment.
why did you need to add a flag here?
There was a problem hiding this comment.
I mistakenly thought that adding New_ would break the existing inference.
orklah
added
the
release:fix
|
Test failure is unrelated, but it looks like you're on an outdated revision |
I've rebase main branch. Tests is ok now. |
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #7541