Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mark loadXdebugStub as deprecated (removed in #7107). #7466

Merged
merged 1 commit into from Jan 22, 2022
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
5 changes: 5 additions & 0 deletions config.xsd
Expand Up @@ -85,6 +85,11 @@
<xs:documentation xml:lang="en">
Default is runtime-specific: if not present, Psalm will only load the Xdebug stub if psalm has unloaded the extension.
</xs:documentation>

<!-- note: for PHPStorm to mark the attribute as deprecated the doc entry has to be *single line* and start with the word `deprecated` -->
<xs:documentation xml:lang="en">
Deprecated. In Psalm 5 extensions will be loaded based on composer.json and overridden with enableExtensions/disableExtensions.
</xs:documentation>
</xs:annotation>
</xs:attribute>
<xs:attribute name="memoizeMethodCallResults" type="xs:boolean" default="false" />
Expand Down
9 changes: 8 additions & 1 deletion psalm-baseline.xml
Expand Up @@ -26,13 +26,14 @@
</PossiblyUnusedProperty>
</file>
<file src="src/Psalm/Config.php">
<DeprecatedProperty occurrences="6">
<DeprecatedProperty occurrences="7">
<code>$codebase-&gt;php_major_version</code>
<code>$codebase-&gt;php_major_version</code>
<code>$codebase-&gt;php_major_version</code>
<code>$codebase-&gt;php_major_version</code>
<code>$codebase-&gt;php_minor_version</code>
<code>$codebase-&gt;php_minor_version</code>
<code>$this-&gt;load_xdebug_stub</code>
</DeprecatedProperty>
<DeprecatedMethod occurrences="3">
<code>getAdditionalFileExtensions</code>
Expand Down Expand Up @@ -386,6 +387,12 @@
<code>$stmt-&gt;expr-&gt;getArgs()[0]</code>
</PossiblyUndefinedIntArrayOffset>
</file>
<file src="src/Psalm/Internal/Cli/Psalm.php">
<DeprecatedProperty occurrences="2">
<code>$config-&gt;load_xdebug_stub</code>
<code>$config-&gt;load_xdebug_stub</code>
</DeprecatedProperty>
</file>
<file src="src/Psalm/Internal/Codebase/ConstantTypeResolver.php">
<DeprecatedClass occurrences="2">
<code>new TEmpty()</code>
Expand Down
2 changes: 2 additions & 0 deletions src/Psalm/Config.php
Expand Up @@ -195,6 +195,8 @@ class Config
/**
* Whether or not to load Xdebug stub
*
* @deprecated going to be removed in Psalm 5
*
* @var bool|null
*/
public $load_xdebug_stub;
Expand Down