Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix proc_open stub for php >= 8.0 #7443

Merged
merged 2 commits into from Jan 21, 2022
Merged

Commits on Jan 20, 2022

  1. Configuration menu
    Copy the full SHA
    9b22d63 View commit details
    Browse the repository at this point in the history

Commits on Jan 21, 2022

  1. unify argument names in historical and current CallMap for proc_open

    Since before 8.0 the named arguments were not part of the interface, we
    don't care about the intermediate steps of the proc_open definition. For
    consistency, this makes the definition the same across all versions.
    
    This also fixes the type for the `options` argument already in
    CallMap_historical to be nullable.
    
    The names of the arguments are now consistent across versions, while the
    delta for 7.4 reflects the change of the `command` argument from
    `string` to `string|array`.
    brainlock committed Jan 21, 2022
    Configuration menu
    Copy the full SHA
    d39ccb5 View commit details
    Browse the repository at this point in the history