Resolve generics of inherited pseudo methods #7430
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See: #7419
This PR contains 2 fixes :
For the second fix, pseudo methods are copied to the child class like storage, so the declaring class is missing. That why tracking of the declaring method id is required, and lookup from
parent_classes
is not required.But, pseudo methods declared on implemented interface are not copied (actual cause of #7198), so resolution of the declaring class like cannot be performed only by a lookup on
declaring_pseudo_method_ids
for this particular case.Should I copy all pseudo_methods (and also declaring_pseudo_method_ids) from implemented interfaces in this PR, or it should be fixed on another PR ?