fix: pass static class name to ReturnTypeAnalyzer

[Patrick-Remy]

As already stated out in PR #7359 and found there:

In these lines the $fq_classlike_name is overriden if the return type is declared in a parent class:

psalm/src/Psalm/Internal/Analyzer/ClassAnalyzer.php

Lines 1871 to 1875 in 549c02d

	$return_type = $codebase->methods->getMethodReturnType(
	$analyzed_method_id,
	$fq_classlike_name,
	$method_analyzer
	);

And then downpassed via ReturnTypeAnalyzer::verifyReturnType to as both $self_class- and $static_class_type-param.

psalm/src/Psalm/Internal/Analyzer/FunctionLike/ReturnTypeAnalyzer.php

Lines 424 to 428 in 549c02d

	$declared_return_type = TypeExpander::expandUnion(
	$codebase,
	$return_type,
	$self_fq_class_name,
	$self_fq_class_name,

The bug is currently not really visible, as e.g. for @return class-string<static> correctly only static::class is allowed and therefor not expected.

[Patrick-Remy]

I fixed (after second try ;-)) that I unintentionally commented-out here the invalid examples
https://github.com/vimeo/psalm/pull/7366/files#diff-ec7956a405a9a30d502695776e76d48768f3bb19238e94eee0897b16856dc3acR12

[orklah]

Thanks! That's great!