Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support multiple <issueHandlers> elements #7354

Merged
merged 1 commit into from Jan 10, 2022

Conversation

wouterj
Copy link
Contributor

@wouterj wouterj commented Jan 9, 2022

Fixes part of #7353

This does not handle deep merging issue handler configs. When defining the same issue handler in 2 <issueHandlers> elements, the latter overrides the first. This is the same behavior as when defining the same issue handler twice in a single <issueHandlers> element.

This is likely to occur when including multiple Psalm config files.
@wouterj wouterj marked this pull request as draft January 9, 2022 13:13
@wouterj wouterj marked this pull request as ready for review January 9, 2022 13:15
@wouterj wouterj mentioned this pull request Jan 9, 2022
@dkarlovi
Copy link
Contributor

See #6888

@orklah orklah added the release:fix The PR will be included in 'Fixes' section of the release notes label Jan 10, 2022
@orklah
Copy link
Collaborator

orklah commented Jan 10, 2022

Thanks!

@orklah orklah merged commit 611583c into vimeo:4.x Jan 10, 2022
@wouterj wouterj deleted the issue-7353/issuehandlers-elements branch January 10, 2022 22:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release:fix The PR will be included in 'Fixes' section of the release notes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants