refactor the TooFewArguments check to start checking with named arguments #7348
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
orklah
force-pushed
the
missing-named-param
branch
2 times, most recently
from
5bd1b85
to
7b93f8a
Compare
orklah
force-pushed
the
missing-named-param
branch
from
7b93f8a
to
9877517
Compare
orklah
added
the
release:fix
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will fix #6491
It turned out to be a much larger change than I anticipated.
I had to change the way we loop over the parameters (to instead loop over arguments). Then it turned out that unpacking was handled globally with a single number, but it's now important to have the number of unpacking of each individual arg.
One slight change, before there was a single TooFewArguments emitted with a message 'expected 2 arguments, saw 1'. Now we'll emit as much TooFewArguments as there are missing arguments and we'll name each one