Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor Reconciler::handleLiteralEquality #7304

Merged
merged 19 commits into from Jan 14, 2022
Merged

Refactor Reconciler::handleLiteralEquality #7304

merged 19 commits into from Jan 14, 2022

Commits on Jan 5, 2022

  1. resolve ClassConst before checking equalities and fix things

    @orklah
    orklah committed Jan 5, 2022
    Configuration menu
    Copy the full SHA
    a8c2fcd View commit details
    Browse the repository at this point in the history

  2. refactor literal int equality check

    @orklah
    orklah committed Jan 5, 2022
    Configuration menu
    Copy the full SHA
    2ada8ee View commit details
    Browse the repository at this point in the history

  3. refactor literal string equality check

    @orklah
    orklah committed Jan 5, 2022
    Configuration menu
    Copy the full SHA
    36349a1 View commit details
    Browse the repository at this point in the history

  4. Fixup!!! make sure to add atomics with the correct offset key

    @orklah
    orklah committed Jan 5, 2022
    Configuration menu
    Copy the full SHA
    950710a View commit details
    Browse the repository at this point in the history

  5. Fixup!!! only allow general TInt to pass

    @orklah
    orklah committed Jan 5, 2022
    Configuration menu
    Copy the full SHA
    3fc8139 View commit details
    Browse the repository at this point in the history

  6. Fixup!!! be more flexible on loose_equality for strings

    @orklah
    orklah committed Jan 5, 2022
    Configuration menu
    Copy the full SHA
    5c0fc46 View commit details
    Browse the repository at this point in the history

  7. Fixup!!! don't allow checks on literals

    @orklah
    orklah committed Jan 5, 2022
    Configuration menu
    Copy the full SHA
    83a02d9 View commit details
    Browse the repository at this point in the history

  8. Fixup!!! don't allow checks on literals

    @orklah
    orklah committed Jan 5, 2022
    Configuration menu
    Copy the full SHA
    411399b View commit details
    Browse the repository at this point in the history

  9. Fixup!!! don't allow checks on literals

    @orklah
    orklah committed Jan 5, 2022
    Configuration menu
    Copy the full SHA
    16bb62b View commit details
    Browse the repository at this point in the history

  10. make sure to keep the origin of the type (from_docblock)

    @orklah
    orklah committed Jan 5, 2022
    Configuration menu
    Copy the full SHA
    8099126 View commit details
    Browse the repository at this point in the history

  11. consistency with string handling

    @orklah
    orklah committed Jan 5, 2022
    Configuration menu
    Copy the full SHA
    c1575d2 View commit details
    Browse the repository at this point in the history

  12. typo

    @orklah
    orklah committed Jan 5, 2022
    Configuration menu
    Copy the full SHA
    e0fb875 View commit details
    Browse the repository at this point in the history

  13. CS

    @orklah
    orklah committed Jan 5, 2022
    Configuration menu
    Copy the full SHA
    7dccfa4 View commit details
    Browse the repository at this point in the history

  14. accept more loose literal equalities and loop over non-literal types … 

    …on a separate loop
    @orklah
    orklah committed Jan 5, 2022
    Configuration menu
    Copy the full SHA
    26542af View commit details
    Browse the repository at this point in the history

  15. refactor float as well

    @orklah
    orklah committed Jan 5, 2022
    Configuration menu
    Copy the full SHA
    fac7317 View commit details
    Browse the repository at this point in the history

  16. remove unused param

    @orklah
    orklah committed Jan 5, 2022
    Configuration menu
    Copy the full SHA
    57e0549 View commit details
    Browse the repository at this point in the history

  17. use the correct type for float function

    @orklah
    orklah committed Jan 5, 2022
    Configuration menu
    Copy the full SHA
    c22670d View commit details
    Browse the repository at this point in the history

  18. fix wrong not literal loose check

    @orklah
    orklah committed Jan 5, 2022
    Configuration menu
    Copy the full SHA
    27c4b07 View commit details
    Browse the repository at this point in the history

Commits on Jan 7, 2022

  1. add new test that was failing before

    @orklah
    orklah committed Jan 7, 2022
    Configuration menu
    Copy the full SHA
    6296a60 View commit details
    Browse the repository at this point in the history