Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

change nullable for array signature to be equal to param signature #7301

Merged
merged 2 commits into from Jan 22, 2022
Merged

change nullable for array signature to be equal to param signature #7301

merged 2 commits into from Jan 22, 2022

Conversation

swiffer
Copy link
Contributor

@swiffer swiffer commented Jan 5, 2022

https://www.php.net/manual/en/function.session-set-cookie-params

Nullable had been set for domain in 7.3 but there is no indication in the docs for that.

Reading the docs again I would assume as domain, path, secure and httponly are nullable as of 8.0 the same is for the array signature:

When using the second signature, an associative array which may have any of the keys lifetime, path, domain, secure, httponly and samesite**. The values have the same meaning as described for the parameters with the same name**. The value of the samesite element should be either Lax or Strict. If any of the allowed options are not given, their default values are the same as the default values of the explicit parameters. If the samesite element is omitted, no SameSite cookie attribute is set.

Follow Up of #7215

@weirdan
Copy link
Collaborator

weirdan commented Jan 5, 2022

In the array form, nulls were accepted since 7.3: https://3v4l.org/MZH5n

@orklah
Copy link
Collaborator

orklah commented Jan 15, 2022

@swiffer is the answer consistent with what you did? Do you have still changes to do or is this ready?

@orklah orklah marked this pull request as draft January 19, 2022 19:39
@swiffer
Copy link
Contributor Author

swiffer commented Jan 22, 2022

@orklah - pretty clear - sorry letting this take so long to correct: looks like all attributes are nullable in array form since 7.3

https://3v4l.org/UjE1B

@orklah orklah added the release:fix The PR will be included in 'Fixes' section of the release notes label Jan 22, 2022
@orklah orklah marked this pull request as ready for review January 22, 2022 15:28
@orklah orklah merged commit 4912139 into vimeo:4.x Jan 22, 2022
@orklah
Copy link
Collaborator

orklah commented Jan 22, 2022

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PR: Needs work release:fix The PR will be included in 'Fixes' section of the release notes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants