more code grooming #7233
Merged
more code grooming #7233
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
orklah
added
the
release:internal
weirdan
reviewed
Dec 28, 2021
| @@ -55,8 +55,6 @@ public static function getFunctionReturnType(FunctionReturnTypeProviderEvent $ev | |||
| ) { | |||
| $filter_type_type = $second_arg_type->getSingleIntLiteral(); | |||
|
|
|||
| $filter_type = null; | |||
There was a problem hiding this comment.
I would actually either leave it here or add a default case to the switch below.
There was a problem hiding this comment.
Did you see this line a little above? https://github.com/vimeo/psalm/pull/7233/files/0b3e1299decdd75fe6cf38acd88391cfea323516#diff-76c8a38ce19c782b153d6a5cbededfe163697de0e37f2f40559f3f07f8eaf318L50
It was just initialized twice
Comment on lines
-104
to
-105
| $lines[$k] = str_replace("\t", ' ', $line); | ||
| $lines[$k] = preg_replace('/^ *\*/', '', $line); |
There was a problem hiding this comment.
It looks like a bug actually, the tab expansion was futile.
There was a problem hiding this comment.
Yeah, this was definitely a bug. Forgot to mention it in the PR. I fixed it the way I think it was intended, but I'm not sure what it was designed to do in what case though...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's pretty minor refactoring, except for what I removed in ParseTreeCreator. What I removed felt important but I couldn't get how it could be useful and tests seems to prove me right...